Ready: Make Riak PB a submodule#418
Merged
Merged
Conversation
… on import errors Getting rid of splat imports Continuing work to fix riak_pb imports Finish up changes to bring in riak_pb as a submodule Small fix for test when security is disabled tweak test lint fixes modify test to fix error Use all https clone urls, updated submodule commit Ensure that tox uses the correct executable for Python 2.7.9 Revert deletion of these files bash script cleanup All tests pass
lukebakken
force-pushed
the
features/lrb/riak_pb-submodule
branch
from
4f47d06 to
9aaf03c
Compare
lukebakken
changed the title
…nd 3.5 series are used
There was a problem hiding this comment.
We can use 3.5 for the source tarball, that's fine, but we'll also see a bdist_egg step for 3.5, too. On second thought, are we even going to maintain riak_pb on PyPI going forward?
Contributor
Author
There was a problem hiding this comment.
Fixed the bdist_egg thing. From here on out riak_pb can be abandoned if you ask me.
# Conflicts: # buildbot/Makefile # buildbot/tox_setup.sh # commands.py # riak/tests/__init__.py # riak/tests/test_all.py # riak/transports/pbc/codec.py # riak/transports/pbc/connection.py # riak/transports/pbc/stream.py # riak/transports/pbc/transport.py # setup.py # tox.ini
|
👍 7885c90 |
borshop
added a commit
that referenced
this pull request
Dec 14, 2015
Ready: Make Riak PB a submodule Reviewed-by: javajolt
|
👍 9c098dd |
borshop
added a commit
that referenced
this pull request
Dec 15, 2015
Ready: Make Riak PB a submodule Reviewed-by: javajolt
|
@borshop merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically takes the Python stuff out of basho/riak_pb and puts it here.